The hydrothermal method was used as a new approach to prepare a series of Ag-doped Cd0.1Zn0.9S photocatalysts. The effect of Ag doping on the properties and photocatalytic activity of Cd0.1Zn0.9S was studied for the hydrogen production from water reduction under visible light irradiation.